github-code/lvgl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(tests): replace sprintf -> lv_snprintf (#5319)

Browse Source 
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
This commit is contained in:
_VIFEXTech
2024-01-15 19:20:04 +08:00
committed by GitHub
parent 751bc99b98
commit e0be0c9253
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/src/test_cases/draw/test_image_formats.c
View File

@@ -258,8 +258,9 @@ static void bin_image_create(bool rotate, bool recolor, int align, int compress)
char path[256]; char path[256];
int stride = stride_align[align]; int stride = stride_align[align];
for(unsigned i = 0; i < sizeof(color_formats) / sizeof(color_formats[0]); i++) { for(unsigned i = 0; i < sizeof(color_formats) / sizeof(color_formats[0]); i++) {
sprintf(name, "bin%s", color_formats[i]); lv_snprintf(name, sizeof(name), "bin%s", color_formats[i]);
sprintf(path, "A:test_images/stride_align%d/%s/test_%s.bin", stride, compressions[compress], color_formats[i]); lv_snprintf(path, sizeof(path), "A:test_images/stride_align%d/%s/test_%s.bin", stride, compressions[compress],
color_formats[i]);
img_create(name, path, rotate, recolor); img_create(name, path, rotate, recolor);
} }
} }
@@ -268,7 +269,7 @@ static void c_array_image_create(bool rotate, bool recolor, int align, int compr
{ {
char name[32]; char name[32];
for(unsigned i = 0; i < sizeof(color_formats) / sizeof(color_formats[0]); i++) { for(unsigned i = 0; i < sizeof(color_formats) / sizeof(color_formats[0]); i++) {
sprintf(name, "%s%s", compressions[compress], color_formats[i]); lv_snprintf(name, sizeof(name), "%s%s", compressions[compress], color_formats[i]);
const void * src = c_array_images[align][compress][i]; const void * src = c_array_images[align][compress][i];
img_create(name, src, rotate, recolor); img_create(name, src, rotate, recolor);
} }
@@ -285,12 +286,13 @@ void test_image_formats()
for(unsigned i = 0; i < sizeof(compressions) / sizeof(compressions[0]); i++) { for(unsigned i = 0; i < sizeof(compressions) / sizeof(compressions[0]); i++) {
char reference[256]; char reference[256];
bin_image_create(rotate, recolor, align, i); bin_image_create(rotate, recolor, align, i);
snprintf(reference, sizeof(reference), "draw/bin_image_stride%d_%s_%s.png", stride, compressions[i], modes[mode]); lv_snprintf(reference, sizeof(reference), "draw/bin_image_stride%d_%s_%s.png", stride, compressions[i], modes[mode]);
TEST_ASSERT_EQUAL_SCREENSHOT(reference); TEST_ASSERT_EQUAL_SCREENSHOT(reference);
lv_obj_clean(lv_screen_active()); lv_obj_clean(lv_screen_active());
c_array_image_create(rotate, recolor, align, i); c_array_image_create(rotate, recolor, align, i);
snprintf(reference, sizeof(reference), "draw/c_array_image_stride%d_%s_%s.png", stride, compressions[i], modes[mode]); lv_snprintf(reference, sizeof(reference), "draw/c_array_image_stride%d_%s_%s.png", stride, compressions[i],
modes[mode]);
TEST_ASSERT_EQUAL_SCREENSHOT(reference); TEST_ASSERT_EQUAL_SCREENSHOT(reference);
lv_obj_clean(lv_screen_active()); lv_obj_clean(lv_screen_active());
} }

2
tests/src/test_cases/widgets/test_spinner.c
View File

@@ -26,7 +26,7 @@ void test_spinner_spinning(void)
lv_task_handler(); lv_task_handler();
char filename[32]; char filename[32];
snprintf(filename, sizeof(filename), "widgets/spinner_%02d.png", i); lv_snprintf(filename, sizeof(filename), "widgets/spinner_%02d.png", i);
TEST_ASSERT_EQUAL_SCREENSHOT(filename); TEST_ASSERT_EQUAL_SCREENSHOT(filename);
} }
} }

4
tests/unity/unity_support.c
View File

@@ -129,7 +129,7 @@ static bool screenhot_compare(const char * fn_ref, const char * mode, uint8_t to
{ {
char fn_ref_full[256]; char fn_ref_full[256];
sprintf(fn_ref_full, "%s%s", REF_IMGS_PATH, fn_ref); lv_snprintf(fn_ref_full, sizeof(fn_ref_full), "%s%s", REF_IMGS_PATH, fn_ref);
lv_refr_now(NULL); lv_refr_now(NULL);
@@ -191,7 +191,7 @@ static bool screenhot_compare(const char * fn_ref, const char * mode, uint8_t to
fn_ref_no_ext[strlen(fn_ref_no_ext) - 4] = '\0'; fn_ref_no_ext[strlen(fn_ref_no_ext) - 4] = '\0';
char fn_err_full[256]; char fn_err_full[256];
sprintf(fn_err_full, "%s%s_err.png", REF_IMGS_PATH, fn_ref_no_ext); lv_snprintf(fn_err_full, sizeof(fn_err_full), "%s%s_err.png", REF_IMGS_PATH, fn_ref_no_ext);
write_png_file(screen_buf_xrgb8888, 800, 480, fn_err_full); write_png_file(screen_buf_xrgb8888, 800, 480, fn_err_full);
} }