From e22a201369463cedc240c253575deb5bb10c636e Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Mon, 17 May 2021 18:37:16 -0400 Subject: [PATCH 1/4] Delete stale.yml It has been extremely unreliable over the last few months. --- .github/stale.yml | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 .github/stale.yml diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index c3d60ea60..000000000 --- a/.github/stale.yml +++ /dev/null @@ -1,17 +0,0 @@ -# Number of days of inactivity before an issue becomes stale -daysUntilStale: 21 -# Number of days of inactivity before a stale issue is closed -daysUntilClose: 7 -# Issues with these labels will never be considered stale -exemptLabels: - - architecture - - pinned -# Label to use when marking an issue as stale -staleLabel: stale -# Comment to post when marking an issue as stale. Set to `false` to disable -markComment: > - This issue or pull request has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. -# Comment to post when closing a stale issue. Set to `false` to disable -closeComment: false From f4bb6eadf52ab1244fb0e94f307a0d4d96318847 Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Mon, 17 May 2021 18:40:00 -0400 Subject: [PATCH 2/4] Create close_old_issues.yml --- .github/workflows/close_old_issues.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/close_old_issues.yml diff --git a/.github/workflows/close_old_issues.yml b/.github/workflows/close_old_issues.yml new file mode 100644 index 000000000..4cd2a6a56 --- /dev/null +++ b/.github/workflows/close_old_issues.yml @@ -0,0 +1,19 @@ +name: 'Close stale issues and PRs' +on: + schedule: + - cron: '30 1 * * *' + +jobs: + stale: + runs-on: ubuntu-latest + steps: + - uses: actions/stale@v3 + with: + repo-token: ${{ secrets.LVGL_BOT_TOKEN }} + stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.' + stale-pr-message: 'This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.' + close-issue-message: 'This issue was closed because it has been stalled for 5 days with no activity.' + days-before-stale: 30 + days-before-close: 5 + exempt-issue-labels: 'pinned' + exempt-pr-labels: 'pinned' From 76d5d468b99b8da113e634d96a649514f3d318ca Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Mon, 17 May 2021 18:56:32 -0400 Subject: [PATCH 3/4] chore(issues) allow dispatching issue closer --- .github/workflows/close_old_issues.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/close_old_issues.yml b/.github/workflows/close_old_issues.yml index 4cd2a6a56..5e8df3138 100644 --- a/.github/workflows/close_old_issues.yml +++ b/.github/workflows/close_old_issues.yml @@ -2,6 +2,7 @@ name: 'Close stale issues and PRs' on: schedule: - cron: '30 1 * * *' + workflow_dispatch: jobs: stale: From 6e8b769d2c2b26b4db7ac3bf8d04e241622ac0ad Mon Sep 17 00:00:00 2001 From: guoweilkd <35251456+guoweilkd@users.noreply.github.com> Date: Tue, 18 May 2021 10:35:10 +0800 Subject: [PATCH 4/4] docs(scroll) fix small problem (#2257) Co-authored-by: guowei15 --- docs/overview/scroll.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/overview/scroll.md b/docs/overview/scroll.md index ea99bc7ea..90286876e 100644 --- a/docs/overview/scroll.md +++ b/docs/overview/scroll.md @@ -64,7 +64,7 @@ Besides managing "normal" scrolling there are many interesting and useful additi ### Scrollable -It's possible to make an object non-scrollable with `lv_obj_add_flag(obj, LV_OBJ_FLAG_SCROLLABLE)`. +It's possible to make an object non-scrollable with `lv_obj_clear_flag(obj, LV_OBJ_FLAG_SCROLLABLE)`. Non-scrollable object can still propagate the scrolling (chain) to the parents. @@ -154,7 +154,7 @@ if(event_code == LV_EVENT_GET_SELF_SIZE) { p->x = 200; //Set or calculate the self width } - if(p->x >= 0) { + if(p->y >= 0) { p->y = 50; //Set or calculate the self height } }