github-code/lvgl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(chart): fix unhandled branch (#3479)

Browse Source 
If chart->type != LV_CHART_TYPE_LINE and != LV_CHART_TYPE_SCATTER and != LV_CHART_TYPE_BAR return sane values

Fixes GCC warning p_out->x may be used uninitialized in this function

Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>

Co-authored-by: Nuno Goncalves <nunog@fr24.com>
This commit is contained in:
Nuno Goncalves
2022-07-13 19:57:39 +01:00
committed by GitHub
parent bfcaaff610
commit 891aee1e8e
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/extra/widgets/chart/lv_chart.c
View File

@@ -309,6 +309,11 @@ void lv_chart_get_point_pos_by_id(lv_obj_t * obj, lv_chart_series_t * ser, uint1
p_out->x += (col_w - ser_gap) / 2; p_out->x += (col_w - ser_gap) / 2;
} }
else {
p_out->x = 0;
p_out->y = 0;
return;
}
lv_coord_t border_width = lv_obj_get_style_border_width(obj, LV_PART_MAIN); lv_coord_t border_width = lv_obj_get_style_border_width(obj, LV_PART_MAIN);
p_out->x += lv_obj_get_style_pad_left(obj, LV_PART_MAIN) + border_width; p_out->x += lv_obj_get_style_pad_left(obj, LV_PART_MAIN) + border_width;